Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi
Date: 2018-04-05 03:35:32
Message-ID: CAH2-Wz=5_Y9e=sSVQjpOqDA=CTLAgEuL=V+jLfNeX9=BKxnm2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Apr 4, 2018 at 8:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> This was discovered while testing/reviewing the latest version of the
>> INCLUDE covering indexes patch. It now seems to be unrelated.
>
> Oh, wait ... I wonder if you saw that because you were running a new
> backend without having re-initdb'd?

Yes. That's what happened.

> Once you had re-initdb'd, then
> of course there would be no old-format btree indexes anywhere. But
> if you hadn't, then anyplace that was not prepared to cope with the
> old header format would complain about pre-existing indexes.
>
> In short, this sounds like a place that did not get the memo about
> how to cope with un-upgraded indexes.

Sounds plausible.

--
Peter Geoghegan

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2018-04-05 08:56:36 pgsql: MERGE post-commit review
Previous Message Tom Lane 2018-04-05 03:28:20 Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi