From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix EXPLAIN ANALYZE output for Parallel Hash. |
Date: | 2018-01-01 22:42:00 |
Message-ID: | E1eW8mO-00039O-Ts@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix EXPLAIN ANALYZE output for Parallel Hash.
In a race case, EXPLAIN ANALYZE could fail to display correct nbatch
and size information. Refactor so that participants report only on
batches they worked on rather than trying to report on all of them,
and teach explain.c to consider the HashInstrumentation object from
all participants instead of picking the first one it can find. This
should fix an occasional build farm failure in the "join" regression
test.
Author: Thomas Munro
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/30219.1514428346%40sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/93ea78b17c4743c2b63edb5998fb5796ae57e289
Modified Files
--------------
src/backend/commands/explain.c | 79 ++++++++++++++++++++++++-------------
src/backend/executor/nodeHash.c | 27 +++++--------
src/backend/executor/nodeHashjoin.c | 6 ---
src/include/executor/nodeHash.h | 1 -
4 files changed, 62 insertions(+), 51 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-01-01 22:42:28 | Re: pgsql: Add parallel-aware hash joins. |
Previous Message | Noah Misch | 2018-01-01 06:06:10 | pgsql: In tests, await an LSN no later than the recovery target. |