| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add parallel-aware hash joins. |
| Date: | 2018-01-01 22:42:28 |
| Message-ID: | 20180101224228.yvmhs4onidw6gdbi@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2017-12-31 10:59:26 +1300, Thomas Munro wrote:
> On Sun, Dec 31, 2017 at 5:16 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> In a race case, EXPLAIN ANALYZE could fail to display correct nbatch and size
> >> information. Refactor so that participants report only on batches they worked
> >> on rather than trying to report on all of them, and teach explain.c to
> >> consider the HashInstrumentation object from all participants instead of
> >> picking the first one it can find. This should fix an occasional build farm
> >> failure in the "join" regression test.
> >
> > This seems buggy independent of whether it fixes the issue on prairedog,
> > right? So I'm inclined to go ahead and just fix it...
>
> +1
Pushed your updated version.
Thanks,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-01-02 03:23:45 | Re: pgsql: Add parallel-aware hash joins. |
| Previous Message | Andres Freund | 2018-01-01 22:42:00 | pgsql: Fix EXPLAIN ANALYZE output for Parallel Hash. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2018-01-02 01:39:56 | Re: Race to build pg_isolation_regress in "make -j check-world" |
| Previous Message | Gavin Flower | 2018-01-01 19:54:25 | Re: What does Time.MAX_VALUE actually represent? |