pgsql: postgres_fdw: Fix test that didn't test what it claimed.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: postgres_fdw: Fix test that didn't test what it claimed.
Date: 2017-12-01 18:50:13
Message-ID: E1eKqO5-0001jC-Uo@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Fix test that didn't test what it claimed.

Antonin Houska reported that the planner does consider pushing
postgres_fdw_abs() to the remote side, which happens because we make
it shippable earlier in the test case file.

Jeevan Chalke provided this patch, which changes the join
condition to use random(), which is not shippable, instead.
Antonin reviewed the patch.

Discussion: http://postgr.es/m/15265.1511985971@localhost

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/950222780535e6d2ea560cd8b3db5308652ddd42

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 24 +++++++++++++-----------
contrib/postgres_fdw/sql/postgres_fdw.sql | 2 +-
2 files changed, 14 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-12-01 18:55:46 pgsql: Minor code beautification in partition_bounds_equal.
Previous Message Robert Haas 2017-12-01 17:57:55 pgsql: Re-allow INSERT .. ON CONFLICT DO NOTHING on partitioned tables.