pgsql: Re-allow INSERT .. ON CONFLICT DO NOTHING on partitioned tables.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Re-allow INSERT .. ON CONFLICT DO NOTHING on partitioned tables.
Date: 2017-12-01 17:57:55
Message-ID: E1eKpZT-0000je-4D@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Re-allow INSERT .. ON CONFLICT DO NOTHING on partitioned tables.

Commit 8355a011a0124bdf7ccbada206a967d427039553 was reverted in
f05230752d53c4aa74cffa9b699983bbb6bcb118, but this attempt is
hopefully better-considered: we now pass the correct value to
ExecOpenIndices, which should avoid the crash that we hit before.

Amit Langote, reviewed by Simon Riggs and by me. Some final
editing by me.

Discussion: http://postgr.es/m/7ff1e8ec-dc39-96b1-7f47-ff5965dceeac@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/87c37e3291cb75273ccdf4645b9472dd805c4493

Modified Files
--------------
doc/src/sgml/ddl.sgml | 13 +++++++++----
src/backend/commands/copy.c | 3 ++-
src/backend/executor/execPartition.c | 15 ++++++++++-----
src/backend/executor/nodeModifyTable.c | 3 ++-
src/backend/parser/analyze.c | 8 --------
src/include/executor/execPartition.h | 3 ++-
src/test/regress/expected/insert_conflict.out | 13 +++++++++++++
src/test/regress/sql/insert_conflict.sql | 13 +++++++++++++
8 files changed, 51 insertions(+), 20 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-12-01 18:50:13 pgsql: postgres_fdw: Fix test that didn't test what it claimed.
Previous Message Robert Haas 2017-12-01 16:08:04 pgsql: Try to exclude partitioned tables in toto.