pgsql: Fix bogus logic for checking data dirs' versions within pg_upgra

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix bogus logic for checking data dirs' versions within pg_upgra
Date: 2017-11-16 16:17:03
Message-ID: E1eFMqd-0005LR-Iw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus logic for checking data dirs' versions within pg_upgrade.

Commit 9be95ef15 failed to cure all of the redundancy here: we were
actually calling get_major_server_version() three times for each
of the old and new data directories. While that's not enormously
expensive, it's still sloppy.

A. Akenteva

Discussion: https://postgr.es/m/f9266a85d918a3cf3a386b5148aee666@postgrespro.ru

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4b02e935fee881eab1f4fabdbebccedfa57b4ddd

Modified Files
--------------
src/bin/pg_upgrade/check.c | 6 +++---
src/bin/pg_upgrade/exec.c | 5 ++---
2 files changed, 5 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2017-11-16 16:21:11 Re: pgsql: Disable installcheck tests for test_session_hooks
Previous Message Tom Lane 2017-11-16 15:36:28 pgsql: Further refactoring of c.h and nearby files.