From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Further refactoring of c.h and nearby files. |
Date: | 2017-11-16 15:36:28 |
Message-ID: | E1eFMDM-0004YM-8x@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Further refactoring of c.h and nearby files.
This continues the work of commit 91aec93e6 by getting rid of a lot of
Windows-specific funny business in "section 0". Instead of including
pg_config_os.h in different places depending on platform, let's
standardize on putting it before the system headers, and in consequence
reduce win32.h to just what has to appear before the system headers or
the body of c.h (the latter category seems to include only PGDLLIMPORT
and PGDLLEXPORT). The rest of what was in win32.h is moved to a new
sub-include of port.h, win32_port.h. Some of what was in port.h seems
to better belong there too.
It's possible that I missed some declaration ordering dependency that
needs to be preserved, but hopefully the buildfarm will find that
out in short order.
Unlike the previous commit, no back-patch, since this is just cleanup
not a prerequisite for a bug fix.
Discussion: https://postgr.es/m/29650.1510761080@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ed9b3606dadb461aac57e41ac509f3892095a394
Modified Files
--------------
src/bin/pg_ctl/pg_ctl.c | 8 -
src/include/c.h | 30 +--
src/include/port.h | 59 +-----
src/include/port/win32.h | 427 ++-----------------------------------
src/include/port/win32_port.h | 483 ++++++++++++++++++++++++++++++++++++++++++
5 files changed, 512 insertions(+), 495 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-11-16 16:17:03 | pgsql: Fix bogus logic for checking data dirs' versions within pg_upgra |
Previous Message | amul sul | 2017-11-16 14:37:07 | Re: [COMMITTERS] pgsql: Add hash partitioning. |