pgsql: Allow up to 3 "-P 1" reports per thread in pgbench run of 2 seco

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Allow up to 3 "-P 1" reports per thread in pgbench run of 2 seco
Date: 2017-09-22 16:59:52
Message-ID: E1dvRIu-0003MD-DL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow up to 3 "-P 1" reports per thread in pgbench run of 2 seconds.

There seems to be some considerable imprecision in the timing of -P
progress reports. Nominally each thread ought to produce 2 reports
in this test, but about 10% of the time we only get one, and 1% of
the time we get three, as per buildfarm results so far. Pending
further investigation, treat the last case as a "pass". (I, tgl,
am suspicious that this still might not be lax enough, now that it's
obvious that the behavior is load-dependent; but there's not yet
buildfarm evidence to confirm that suspicion.)

Fabien Coelho

Discussion: https://postgr.es/m/26654.1505232433@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0f574a7afb5c998d19dc3d981e45cb10267286ed

Modified Files
--------------
src/bin/pgbench/t/001_pgbench_with_server.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-22 17:30:14 Re: pgsql: Accept that server might not be able to send error in crash reco
Previous Message Peter Eisentraut 2017-09-22 15:50:02 pgsql: Remove contrib/chkpass