Re: pgsql: Accept that server might not be able to send error in crash reco

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Accept that server might not be able to send error in crash reco
Date: 2017-09-22 17:30:14
Message-ID: 14968.1506101414@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Accept that server might not be able to send error in crash recovery test.

piculet says you didn't cover all the bases:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet&dt=2017-09-22%2017%3A10%3A01

Looks like you missed adding the "server closed the connection
unexpectedly" alternative to one of the three places.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-09-22 17:36:30 Re: pgsql: Accept that server might not be able to send error in crash reco
Previous Message Tom Lane 2017-09-22 16:59:52 pgsql: Allow up to 3 "-P 1" reports per thread in pgbench run of 2 seco