pgsql: Fix over-aggressive sanity check in misc_sanity.sql.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix over-aggressive sanity check in misc_sanity.sql.
Date: 2017-08-28 14:15:05
Message-ID: E1dmKoj-000865-Tg@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix over-aggressive sanity check in misc_sanity.sql.

Fix thinko in commit 8be8510cf: it's okay to have dbid == 0 in normal
(non-pin) entries in pg_shdepend, because global objects such as
databases are entered that way. The test would pass so long as it
was run in a cluster containing no databases/tablespaces owned by,
or granted to, roles other than the bootstrap superuser. That's the
expected situation for "make check", but for "make installcheck", not
so much.

Reported by Ryan Murphy.

Discussion: https://postgr.es/m/CAHeEsBc6EQe0mxGBKDXAwJbntgfvoAd5MQC-5362SmC3Tng_6g@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/df44405a0c5c725706317c1faa6e8a0760f17dcc

Modified Files
--------------
src/test/regress/expected/misc_sanity.out | 2 +-
src/test/regress/sql/misc_sanity.sql | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2017-08-28 14:16:31 Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.
Previous Message Robert Haas 2017-08-28 14:08:44 Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.