From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix thinko introduced in 2bef06d516460 et al. |
Date: | 2017-08-06 21:37:26 |
Message-ID: | E1deTEk-0000n7-Hx@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix thinko introduced in 2bef06d516460 et al.
The callers for GetOldestSafeDecodingTransactionId() all inverted the
argument for the argument introduced in 2bef06d516460. Luckily this
appears to be inconsequential for the moment, as we wait for
concurrent in-progress transaction when assembling a
snapshot. Additionally this could only make a difference when adding a
second logical slot, because only a pre-existing slot could cause an
issue by lowering the returned xid dangerously much.
Reported-By: Antonin Houska
Discussion: https://postgr.es/m/32704.1496993134@localhost
Backport: 9.4-, where 2bef06d516460 was backpatched to.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5af4456a56472e1928e838c893eb0022f7ab28fb
Modified Files
--------------
src/backend/replication/logical/logical.c | 2 +-
src/backend/replication/logical/snapbuild.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-08-06 21:37:27 | pgsql: Fix thinko introduced in 2bef06d516460 et al. |
Previous Message | Andres Freund | 2017-08-05 22:06:08 | pgsql: Fix issues with wide tuples being updated and REPLICA IDENTITY F |