From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix issues with wide tuples being updated and REPLICA IDENTITY F |
Date: | 2017-08-05 22:06:08 |
Message-ID: | E1de7Cy-0007M9-QO@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix issues with wide tuples being updated and REPLICA IDENTITY FULL.
When replica identity full is being used with a wide tuple (above 2^16
bytes after compression) it lead to errors and/or crashes during
decoding because the length field used to store such tuples doesn't
fit into the variable used to store the width in the WAL record.
To fix, discontinue use of xl_heap_header_len.t_len when decoding the
old tuple version, instead compute length of the old tuple by
subtracting the new tuple's length from the record length.
In newer version of postgres this issue is moot because the length is
stored by the new WAL machinery, instead of a xl_heap_header_len
struct. A separate commit will forward-patch the regression test.
Reported-By: "anderson"
Discussion: http://postgr.es/m/20170105144819.f6i5o64vfvy4bn5i@alap3.anarazel.de
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/23a2b818f50ff9e1beb73c31cd902a2140476c30
Modified Files
--------------
contrib/test_decoding/expected/toast.out | 8 +++++++-
contrib/test_decoding/sql/toast.sql | 3 ++-
src/backend/access/heap/heapam.c | 8 +++++++-
src/backend/replication/logical/decode.c | 19 ++++++++++++++++---
4 files changed, 32 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-08-06 21:37:26 | pgsql: Fix thinko introduced in 2bef06d516460 et al. |
Previous Message | Andres Freund | 2017-08-05 22:06:07 | pgsql: Add regression test for wide REPLICA IDENTITY FULL updates. |