pgsql: Re-allow SRFs and window functions within sub-selects within agg

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Re-allow SRFs and window functions within sub-selects within agg
Date: 2017-06-27 21:51:28
Message-ID: E1dPyOO-0002gn-4O@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Re-allow SRFs and window functions within sub-selects within aggregates.

check_agg_arguments_walker threw an error upon seeing a SRF or window
function, but that is too aggressive: if the function is within a
sub-select then it's perfectly fine. I broke the SRF case in commit
0436f6bde by copying the logic for window functions ... but that was
broken too, and had been since commit eaccfded9.

Repair both cases in HEAD, and the window function case back to 9.3.
9.2 gets this right.

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dc777f9db3e9a5f979f4f847c96949ca5555f355

Modified Files
--------------
src/backend/parser/parse_agg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-06-27 22:48:28 pgsql: Support tcp_keepalives_idle option on Solaris.
Previous Message Tom Lane 2017-06-26 23:01:36 pgsql: Reduce wal_retrieve_retry_interval in applicable TAP tests.