pgsql: Reduce wal_retrieve_retry_interval in applicable TAP tests.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Reduce wal_retrieve_retry_interval in applicable TAP tests.
Date: 2017-06-26 23:01:36
Message-ID: E1dPd0i-00025v-Pl@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Reduce wal_retrieve_retry_interval in applicable TAP tests.

By default, wal_retrieve_retry_interval is five seconds, which is far
more than is needed in any of our TAP tests, leaving the test cases
just twiddling their thumbs for significant stretches. Moreover,
because it's so large, we get basically no testing of the retry-before-
master-is-ready code path. Hence, make PostgresNode::init set up
wal_retrieve_retry_interval = '500ms' as part of its customization of
test clusters' postgresql.conf. This shaves quite a few seconds off
the runtime of the recovery TAP tests.

Back-patch into 9.6. We have wal_retrieve_retry_interval in 9.5,
but the test infrastructure isn't there.

Discussion: https://postgr.es/m/31624.1498500416@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2710ccd782d0308a3fa1ab193531183148e9b626

Modified Files
--------------
src/test/perl/PostgresNode.pm | 1 +
1 file changed, 1 insertion(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-06-27 21:51:28 pgsql: Re-allow SRFs and window functions within sub-selects within agg
Previous Message Tom Lane 2017-06-26 21:32:21 pgsql: Don't lose walreceiver start requests due to race condition in p