| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Recommend wrappers of PG_DETOAST_DATUM_PACKED(). |
| Date: | 2017-03-12 23:41:40 |
| Message-ID: | E1cnD7M-00034K-TR@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Recommend wrappers of PG_DETOAST_DATUM_PACKED().
When commit 3e23b68dac006e8deb0afa327e855258df8de064 introduced
single-byte varlena headers, its fmgr.h changes presented
PG_GETARG_TEXT_PP() and PG_GETARG_TEXT_P() as equals. Its postgres.h
changes presented PG_DETOAST_DATUM_PACKED() and VARDATA_ANY() as the
exceptional case. Now, instead, firmly recommend PG_GETARG_TEXT_PP()
over PG_GETARG_TEXT_P(); likewise for other ...PP() macros. This shaves
cycles and invites consistency of style.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/9d7726c2ba06b932f791f2d0cc5acf73cc0b4dca
Modified Files
--------------
doc/src/sgml/xfunc.sgml | 32 +++++++++++++++++++-------------
src/include/c.h | 9 +++++----
src/include/fmgr.h | 34 +++++++++++++++++++++-------------
src/include/postgres.h | 26 ++++++++++++--------------
src/include/utils/inet.h | 5 +++--
src/tutorial/funcs_new.c | 29 ++++++++++++++++-------------
6 files changed, 76 insertions(+), 59 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2017-03-13 11:11:33 | pgsql: Fix typo in comment |
| Previous Message | David Rowley | 2017-03-12 21:44:29 | Re: pgsql: dblink: Replace some macros by static functions |