Re: pgsql: dblink: Replace some macros by static functions

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: dblink: Replace some macros by static functions
Date: 2017-03-12 21:44:29
Message-ID: CAKJS1f9a=dyzbP3xrn7nHgEk-tNjXKybRV_csJRptzCp=hLCsA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 11 March 2017 at 03:46, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> dblink: Replace some macros by static functions
>
> Also remove some unused code and the no longer useful dblink.h file.
>
> Reviewed-by: Tsunakawa, Takayuki <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/acaf7ccb94a3916ea83712671a3563
> f0eb595558
>
> Modified Files
> --------------
> contrib/dblink/dblink.c | 290 +++++++++++++++++++++++-------
> ------------------
> contrib/dblink/dblink.h | 39 -------
> 2 files changed, 137 insertions(+), 192 deletions(-)
>

Hi Peter,

Please accept a small patch which fixes a new compiler warning which
started as a result of this commit.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
dblink_compiler_warning_fix.patch application/octet-stream 442 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2017-03-12 23:41:40 pgsql: Recommend wrappers of PG_DETOAST_DATUM_PACKED().
Previous Message Tom Lane 2017-03-12 20:01:47 pgsql: Add "break"s to make it clearer what will happen in a nested swi