From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Invalidate cached plans on FDW option changes. |
Date: | 2017-01-06 19:13:09 |
Message-ID: | E1cPZwr-0005SQ-5V@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Invalidate cached plans on FDW option changes.
This fixes problems where a plan must change but fails to do so,
as seen in a bug report from Rajkumar Raghuwanshi.
For ALTER FOREIGN TABLE OPTIONS, do this through the standard method of
forcing a relcache flush on the table. For ALTER FOREIGN DATA WRAPPER
and ALTER SERVER, just flush the whole plan cache on any change in
pg_foreign_data_wrapper or pg_foreign_server. That matches the way
we handle some other low-probability cases such as opclass changes, and
it's unclear that the case arises often enough to be worth working harder.
Besides, that gives a patch that is simple enough to back-patch with
confidence.
Back-patch to 9.3. In principle we could apply the code change to 9.2 as
well, but (a) we lack postgres_fdw to test it with, (b) it's doubtful that
anyone is doing anything exciting enough with FDWs that far back to need
this desperately, and (c) the patch doesn't apply cleanly.
Patch originally by Amit Langote, reviewed by Etsuro Fujita and Ashutosh
Bapat, who each contributed substantial changes as well.
Discussion: https://postgr.es/m/CAKcux6m5cA6rRPTKkqVdJ-R=KKDfe35Q_ZuUqxDSV_4hwga=og@mail.gmail.com
Branch
------
REL9_5_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/aaf12e577ee9bfe71aae43879e41007628ad1143
Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 57 ++++++++++++++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql | 15 +++++++
src/backend/commands/tablecmds.c | 6 +++
src/backend/utils/cache/plancache.c | 2 +
4 files changed, 80 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2017-01-06 20:28:34 | pgsql: Protect against NULL-dereference in pg_dump |
Previous Message | Bruce Momjian | 2017-01-06 16:14:57 | Re: pgsql: Update copyright for 2017 |