pgsql: Protect against NULL-dereference in pg_dump

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Protect against NULL-dereference in pg_dump
Date: 2017-01-06 20:28:34
Message-ID: E1cPb7q-0006n8-3y@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Protect against NULL-dereference in pg_dump

findTableByOid() is allowed to return NULL and we should therefore be
checking for that case. getOwnedSeqs() and dumpSequence() shouldn't
ever actually see this happen, but given odd circumstances it might and
commit f9e439b1 probably shouldn't have removed that check.

Pointed out by Coverity. Initial patch from Michael Paquier.

Back-patch to 9.6, where that commit had removed the check.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d74ecbc8d85eb7a2aa1d5516c5c38d6ab0cbbd82

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-01-06 21:22:18 pgsql: Merge two copies of tuple-building code in pltcl.c.
Previous Message Tom Lane 2017-01-06 19:13:09 pgsql: Invalidate cached plans on FDW option changes.