pgAdmin 4 commit: Fix various cosmetic issues with preference dialog

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin 4 commit: Fix various cosmetic issues with preference dialog
Date: 2016-06-08 12:29:52
Message-ID: E1bAccK-0006zB-Jk@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fix various cosmetic issues with preference dialog

1. Foreign keys listed twice
The label for Exclusion constraint was set to 'Foreign keys'. fixed it.
2. Trigger function, Unique constraint, Primary key should be in title case
3. if user click outside of Preferences window it disappear (it should not disappear)
set preference alertify dialog option closableByDimmer to false.
4. Columns node settings listed twice
Override the register_preferences method in Columns CatalogObjectColumnsModule class
because there are two types of columns node, catalogs columns and tables columns.
so the settings for table columns should also work for catalog columns. Thats why we are not showing preference option for catalogs column node.
Ashesh fixed this issue.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=802840fd7f1419f0cea6b5b4e5d0b30d15b420b5
Author: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>

Modified Files
--------------
.../databases/schemas/catalog_objects/columns/__init__.py | 12 ++++++++++++
.../servers/databases/schemas/functions/__init__.py | 2 +-
.../tables/constraints/exclusion_constraint/__init__.py | 2 +-
.../schemas/tables/constraints/index_constraint/__init__.py | 4 ++--
.../databases/schemas/tables/templates/table/js/table.js | 2 +-
web/pgadmin/preferences/templates/preferences/preferences.js | 3 ++-
6 files changed, 19 insertions(+), 6 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-08 12:29:57 Re: [pgAdmin4][Patch]: RM#1277 - Few cosmetic issues with preference dialog
Previous Message Dave Page 2016-06-08 12:22:13 Re: [pgAdmin4][Debugger][Patch]: RM-1225 - Debugger start error if function contains special characters