Re: [pgAdmin4][Patch]: RM#1277 - Few cosmetic issues with preference dialog

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM#1277 - Few cosmetic issues with preference dialog
Date: 2016-06-08 12:29:57
Message-ID: CA+OCxow4Oi8xTAUicmJiKd7kHVSV+gYbiJqmw6UA5AwOThtSmQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Jun 6, 2016 at 9:45 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the patch for issues fixed:
> 1. Foreign keys listed twice
> The label for Exclusion constraint was set to 'Foreign keys'. fixed it.
> 2. Trigger function, Unique constraint, Primary key should be in title case
> 3. if user click outside of Preferences window it disappear (it should not
> disappear)
> set preference alertify dialog option closableByDimmer to false.
> 4. Columns node settings listed twice
> Override the register_preferences method in Columns
> CatalogObjectColumnsModule class
> because there are two types of columns node, catalogs columns and tables
> columns.
> so the settings for table columns should also work for catalog columns.
> Thats why we are not showing preference option for catalogs column node.
> Ashesh fixed this issue.
>
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-08 12:37:05 Re: [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework
Previous Message Dave Page 2016-06-08 12:29:52 pgAdmin 4 commit: Fix various cosmetic issues with preference dialog