From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Further minor improvement in generic_xlog.c: always say REGBUF_S |
Date: | 2016-04-10 04:24:35 |
Message-ID: | E1ap6vL-0003KE-Lm@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Further minor improvement in generic_xlog.c: always say REGBUF_STANDARD.
Since we're requiring pages handled by generic_xlog.c to be standard
format, specify REGBUF_STANDARD when doing a full-page image, so that
xloginsert.c can compress out the "hole" between pd_lower and pd_upper.
Given the current API in which this path will be taken only for a newly
initialized page, the hole is likely to be particularly large in such
cases, so that this oversight could easily be performance-significant.
I don't notice any particular change in the runtime of contrib/bloom's
regression test, though.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/660d5fb856c61df2de2cedb26249404ffc58cb89
Modified Files
--------------
src/backend/access/transam/generic_xlog.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2016-04-10 06:01:02 | Re: [COMMITTERS] pgsql: Bloom index contrib module |
Previous Message | Tom Lane | 2016-04-10 02:08:01 | Re: [COMMITTERS] pgsql: Bloom index contrib module |