Re: [COMMITTERS] pgsql: Bloom index contrib module

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Bloom index contrib module
Date: 2016-04-10 02:08:01
Message-ID: 5835.1460254081@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> I was depressed, though not entirely surprised, to find that you get
> exactly that same line-count coverage if the table size is cut back
> to ONE row.

Oh, I found the flaw in my testing: there are two INSERTs in the test
script and I was changing only one of them. After correcting that,
the results behave a little more sanely:

Line Coverage Functions
1 row: 70.4 % 349 / 496 93.1 % 27 / 29
10 row: 73.6 % 365 / 496 93.1 % 27 / 29
100 rows: 73.6 % 365 / 496 93.1 % 27 / 29
1000 rows: 75.4 % 374 / 496 93.1 % 27 / 29

Still, we've reached the most coverage this test can give us at 1000
rows, which still means it's wasting the last 99% of its runtime.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-10 04:24:35 pgsql: Further minor improvement in generic_xlog.c: always say REGBUF_S
Previous Message Tom Lane 2016-04-10 01:49:03 Re: [COMMITTERS] pgsql: Bloom index contrib module

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2016-04-10 03:00:17 Re: Performance improvement for joins where outer side is unique
Previous Message Tom Lane 2016-04-10 01:49:03 Re: [COMMITTERS] pgsql: Bloom index contrib module