From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Code and docs review for multiple -c and -f options in psql. |
Date: | 2015-12-13 19:52:13 |
Message-ID: | E1a8Cgn-0006xb-IX@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Code and docs review for multiple -c and -f options in psql.
Commit d5563d7df94488bf drew complaints from Coverity, which quite
correctly complained that one copy of each -c or -f string was being
leaked. What's more, simple_action_list_append was allocating enough space
for still a third copy of each string as part of the SimpleActionListCell,
even though that coding method had been superseded by a separate strdup
operation. There were some other minor coding infelicities too. The
documentation needed more work as well, eg it forgot to explain that -c
causes psql not to accept any interactive input.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/fcbbf82d2b6caf7b156f2ec35b322e23caf1e99e
Modified Files
--------------
doc/src/sgml/ref/psql-ref.sgml | 140 +++++++++++++++++++++++-----------------
src/bin/psql/startup.c | 93 ++++++++++++--------------
2 files changed, 121 insertions(+), 112 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-12-14 02:16:04 | Re: pgsql: Code and docs review for multiple -c and -f options in psql. |
Previous Message | Andres Freund | 2015-12-13 17:57:25 | Re: pgsql: Fix bug leading to restoring unlogged relations from empty files |