Re: pgsql: Fix bug leading to restoring unlogged relations from empty files

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix bug leading to restoring unlogged relations from empty files
Date: 2015-12-13 17:57:25
Message-ID: 20151213175725.GY14789@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2015-12-13 12:37:18 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Fix bug leading to restoring unlogged relations from empty files.
>
> Coverity thinks, quite correctly AFAICS, that this line you wrote in
> FlushOneBuffer() is useless:
>
> LWLockHeldByMe(bufHdr->content_lock);
>
> Perhaps you meant
>
> Assert(LWLockHeldByMe(bufHdr->content_lock));
>

Yes :(. I'll be back at my computer in a couple hours and will fix it
then or tomorrow morning.

Andres

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-12-13 19:52:13 pgsql: Code and docs review for multiple -c and -f options in psql.
Previous Message Tom Lane 2015-12-13 17:37:18 Re: pgsql: Fix bug leading to restoring unlogged relations from empty files