| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Remove special cases for ETXTBSY from new fsync'ing logic. |
| Date: | 2015-05-29 19:11:58 |
| Message-ID: | E1YyPhG-0004Uh-3P@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove special cases for ETXTBSY from new fsync'ing logic.
The argument that this is a sufficiently-expected case to be silently
ignored seems pretty thin. Andres had brought it up back when we were
still considering that most fsync failures should be hard errors, and it
probably would be legit not to fail hard for ETXTBSY --- but the same is
true for EROFS and other cases, which is why we gave up on hard failures.
ETXTBSY is surely not a normal case, so logging the failure seems fine
from here.
Branch
------
REL9_0_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/bf2f20c086a04e7705a4e856d6cc9ebda3eb0017
Modified Files
--------------
src/backend/storage/file/fd.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2015-05-29 19:59:18 | Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal. |
| Previous Message | Tom Lane | 2015-05-29 17:26:27 | pgsql: Check that all aliases of a built-in function have same leakproo |