Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.
Date: 2015-05-29 19:59:18
Message-ID: 5568C516.6040909@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 5/29/15 1:05 PM, Tom Lane wrote:
> Adjust initdb to also not consider fsync'ing failures fatal.

This introduces a failure in the initdb tests, which expect that

initdb -S -D /notthere

returns a nonzero exit code.

The output of that command is also a bit crazy now:

$ pg-install/bin/initdb -S -D /notthere
syncing data to disk ... initdb: could not stat file
"/notthere/pg_xlog": No such file or directory
initdb: could not open directory "/notthere": No such file or directory
initdb: could not open directory "/notthere/pg_tblspc": No such file or
directory
ok

I think the behavior to ignore fsync failures should probably not apply
to top-level directories. Or alternatively, the existence of these
directories should be checked separately.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-05-29 20:06:06 Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.
Previous Message Tom Lane 2015-05-29 19:11:58 pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.