Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.
Date: 2015-05-29 20:06:06
Message-ID: 27843.1432929966@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On 5/29/15 1:05 PM, Tom Lane wrote:
>> Adjust initdb to also not consider fsync'ing failures fatal.

> This introduces a failure in the initdb tests, which expect that
> initdb -S -D /notthere
> returns a nonzero exit code.

Hm, I guess we don't run anything else that touches the DB directory
in this case? In the backend case we'd have failed much earlier.

I'm not 100% convinced that the test case's expectation is necessarily
the right thing, though.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-05-29 21:03:04 pgsql: initdb -S should now have an explicit check that $PGDATA is vali
Previous Message Peter Eisentraut 2015-05-29 19:59:18 Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.