pgsql: Run pg_upgrade and pg_resetxlog with restricted token on Windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Run pg_upgrade and pg_resetxlog with restricted token on Windows
Date: 2015-03-30 21:20:00
Message-ID: E1Ych6G-0002DP-8h@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Run pg_upgrade and pg_resetxlog with restricted token on Windows

As with initdb these programs need to run with a restricted token, and
if they don't pg_upgrade will fail when run as a user with Adminstrator
privileges.

Backpatch to all live branches. On the development branch the code is
reorganized so that the restricted token code is now in a single
location. On the stable bramches a less invasive change is made by
simply copying the relevant code to pg_upgrade.c and pg_resetxlog.c.

Patches and bug report from Muhammad Asif Naeem, reviewed by Michael
Paquier, slightly edited by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fa1e5afa8a26d467aec7c8b36a0b749b690f636c

Modified Files
--------------
contrib/pg_upgrade/pg_upgrade.c | 3 +
src/bin/initdb/initdb.c | 170 +----------------------------
src/bin/pg_resetxlog/pg_resetxlog.c | 3 +
src/common/Makefile | 2 +-
src/common/restricted_token.c | 193 +++++++++++++++++++++++++++++++++
src/include/common/restricted_token.h | 24 ++++
src/test/regress/pg_regress.c | 105 ++----------------
src/tools/msvc/Mkvcbuild.pm | 3 +-
8 files changed, 235 insertions(+), 268 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2015-03-30 21:20:02 pgsql: Run pg_upgrade and pg_resetxlog with restricted token on Windows
Previous Message Tom Lane 2015-03-30 20:40:25 pgsql: Fix bogus concurrent use of _hash_getnewbuf() in bucket split co