| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Remove ill-conceived Assertion in ProcessClientWriteInterrupt(). |
| Date: | 2015-02-03 22:57:28 |
| Message-ID: | E1YImPQ-0007sW-SS@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove ill-conceived Assertion in ProcessClientWriteInterrupt().
It's perfectly fine to have blocked interrupts when
ProcessClientWriteInterrupt() is called. In fact it's commonly the
case when emitting error reports. And we deal with that correctly.
Even if that'd not be the case, it'd be a bad location for such a
assertion. Because ProcessClientWriteInterrupt() is only called when
the socket is blocked it's hard to hit.
Per Heikki and buildfarm animals nightjar and dunlin.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/3a54f4a4944b849846c5a1494810ea06bd6601b7
Modified Files
--------------
src/backend/tcop/postgres.c | 2 --
1 file changed, 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-02-03 23:10:22 | Re: Re: [COMMITTERS] pgsql: Process 'die' interrupts while reading/writing from the client s |
| Previous Message | Heikki Linnakangas | 2015-02-03 22:47:03 | Re: [COMMITTERS] pgsql: Process 'die' interrupts while reading/writing from the client s |