From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Process 'die' interrupts while reading/writing from the client s |
Date: | 2015-02-03 23:10:22 |
Message-ID: | 20150203231022.GA24976@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 2015-02-04 00:47:03 +0200, Heikki Linnakangas wrote:
> On 02/03/2015 11:51 PM, Andres Freund wrote:
> >+ * This is called just after low-level writes. That might be after the read
> >+ * finished successfully, or it was interrupted via interrupt. 'blocked' tells
> >+ * us whether the
>
> Looks like you forgot to complete that sentence before pushing...
>
> Also, nightjar is unhappy with this:
>
> TRAP: FailedAssertion("!(InterruptHoldoffCount == 0 && CritSectionCount ==
> 0)", File:
> "/pgbuild/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/postgres.c", Line:
> 574)
>
> I think that assertion in ProcessClientWriteInterrupt() should be simply
> removed. ProcessClientWriteInterrupt() copes just fine, i.e. does nothing,
> if we're in a critical section or interrupts are held.
Yea, it really was just a brainfart on my endq. It's perfectly normal to be called
that way during error handling...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | pgsql | 2015-02-04 00:07:20 | pgsql: Tag refs/tags/REL9_4_1 was created |
Previous Message | Andres Freund | 2015-02-03 22:57:28 | pgsql: Remove ill-conceived Assertion in ProcessClientWriteInterrupt(). |
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Yetter | 2015-02-03 23:26:01 | GRANT USAGE on FOREIGN SERVER exposes passwords |
Previous Message | Fabrízio de Royes Mello | 2015-02-03 23:09:38 | Re: Proposal : REINDEX xxx VERBOSE |