pgsql: Avoid instability in output of new REINDEX SCHEMA test.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid instability in output of new REINDEX SCHEMA test.
Date: 2014-12-12 20:49:20
Message-ID: E1XzX9M-0001XO-SZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid instability in output of new REINDEX SCHEMA test.

The planner seems to like to do this join query as a hash join, making
the output ordering machine-dependent; worse, it's a hash on OIDs, so
that it's a bit astonishing that the result doesn't change from run to
run even on one machine. Add an ORDER BY to get consistent results.
Per buildfarm.

I also suppressed output from the final DROP SCHEMA CASCADE, to avoid
occasional failures similar to those fixed in commit 81d815dc3ed74a7d.
That hasn't been observed in the buildfarm yet, but it seems likely
to happen in future if we leave it as-is.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1c5c70df45714f38c033bb1a272d8db4f2dc8a2f

Modified Files
--------------
src/test/regress/expected/create_index.out | 36 +++++++++++++---------------
src/test/regress/sql/create_index.sql | 15 +++++++-----
2 files changed, 25 insertions(+), 26 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-12-12 21:14:50 Re: pgsql: doc: restrictions on alter database moving default tablespace
Previous Message Andrew Dunstan 2014-12-12 20:41:40 pgsql: Add several generator functions for jsonb that exist for json.