Re: pgsql: doc: restrictions on alter database moving default tablespace

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: doc: restrictions on alter database moving default tablespace
Date: 2014-12-12 21:14:50
Message-ID: 20141212211450.GA7456@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Oct 21, 2014 at 01:38:43AM -0400, Noah Misch wrote:
> On Sat, Oct 18, 2014 at 02:23:46PM +0000, Bruce Momjian wrote:
> > doc: restrictions on alter database moving default tablespace
> >
> > Mention tablespace must be empty and no one connected to the database.
>
> The database must not contain any object explicitly assigned to its future
> default tablespace, but that tablespace need not be empty. Objects of other
> databases in the tablespace pose no problem.

I am back to look at this comment, and I don't understand what change is
being requested. Are you saying it is just the commit message that
isn't clear?

The new text is:

The new default tablespace for this database must be empty, and no one
can be connected to the database.

That makes the distinction that only the tablespace for the existing
database has to be empty, not the entire tablespace. Also, how would
there be an entry in the new-default per-database tablespace without it
being explicitly assigned, as that was not the previous default.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-12-13 16:22:34 pgsql: Remove duplicate #define
Previous Message Tom Lane 2014-12-12 20:49:20 pgsql: Avoid instability in output of new REINDEX SCHEMA test.