pgsql: pg_recvlogical.c code review.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_recvlogical.c code review.
Date: 2014-10-01 15:42:00
Message-ID: E1XZM2S-0006WX-Px@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_recvlogical.c code review.

Several comments still referred to 'initiating', 'freeing', 'stopping'
replication slots. These were terms used during different phases of
the development of logical decoding, but are no long accurate.

Also rename StreamLog() to StreamLogicalLog() and add 'void' to the
prototype.

Author: Michael Paquier, with some editing by me.

Backpatch to 9.4 where pg_recvlogical was introduced.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fdf81c9a6cf94921084e52c8d2ff903bae362620

Modified Files
--------------
src/bin/pg_basebackup/pg_recvlogical.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2014-10-01 15:42:02 pgsql: pg_recvlogical.c code review.
Previous Message Heikki Linnakangas 2014-10-01 13:43:46 pgsql: Remove num_xloginsert_locks GUC, replace with a #define