pgsql: pg_recvlogical.c code review.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_recvlogical.c code review.
Date: 2014-10-01 15:42:02
Message-ID: E1XZM2U-0006XC-JP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_recvlogical.c code review.

Several comments still referred to 'initiating', 'freeing', 'stopping'
replication slots. These were terms used during different phases of
the development of logical decoding, but are no long accurate.

Also rename StreamLog() to StreamLogicalLog() and add 'void' to the
prototype.

Author: Michael Paquier, with some editing by me.

Backpatch to 9.4 where pg_recvlogical was introduced.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/0cadfee37fba0e60a763c62b2d9010b9a2f15b5e

Modified Files
--------------
src/bin/pg_basebackup/pg_recvlogical.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2014-10-01 17:28:23 pgsql: Fix damange from wrongly split commit in fdf81c9a6cf94.
Previous Message Andres Freund 2014-10-01 15:42:00 pgsql: pg_recvlogical.c code review.