pgsql: Un-break peer authentication.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Un-break peer authentication.
Date: 2014-03-28 14:30:41
Message-ID: E1WTXnt-0005Xk-VH@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Un-break peer authentication.

Commit 613c6d26bd42dd8c2dd0664315be9551475b8864 sloppily replaced a
lookup of the UID obtained from getpeereid() with a lookup of the
server's own user name, thus totally destroying peer authentication.
Revert. Per report from Christoph Berg.

In passing, make sure get_user_name() zeroes *errstr on success on
Windows as well as non-Windows. I don't think any callers actually
depend on this ATM, but we should be consistent across platforms.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b777be0d48a042f500cac72140ffb50392973aa2

Modified Files
--------------
src/backend/libpq/auth.c | 16 ++++++++--------
src/common/username.c | 2 ++
2 files changed, 10 insertions(+), 8 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2014-03-28 14:33:22 Re: pgsql: Un-break peer authentication.
Previous Message Tom Lane 2014-03-27 21:15:49 pgsql: Improve documentation note about Python 2.3 and cdecimal.