| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Un-break peer authentication. |
| Date: | 2014-03-28 14:33:22 |
| Message-ID: | 20140328143322.GA18523@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Mar 28, 2014 at 02:30:41PM +0000, Tom Lane wrote:
> Un-break peer authentication.
>
> Commit 613c6d26bd42dd8c2dd0664315be9551475b8864 sloppily replaced a
> lookup of the UID obtained from getpeereid() with a lookup of the
> server's own user name, thus totally destroying peer authentication.
> Revert. Per report from Christoph Berg.
>
> In passing, make sure get_user_name() zeroes *errstr on success on
> Windows as well as non-Windows. I don't think any callers actually
> depend on this ATM, but we should be consistent across platforms.
Uh, I was working on a patch to fix this and still have it match what we
have in common/username.c. I will merge my changes in.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-03-28 15:50:10 | pgsql: Fix EquivalenceClass processing for nested append relations. |
| Previous Message | Tom Lane | 2014-03-28 14:30:41 | pgsql: Un-break peer authentication. |