From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix length checking for Unicode identifiers containing escapes ( |
Date: | 2014-02-13 19:25:27 |
Message-ID: | E1WE1uZ-0001IV-Ou@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix length checking for Unicode identifiers containing escapes (U&"...").
We used the length of the input string, not the de-escaped string, as
the trigger for NAMEDATALEN truncation. AFAICS this would only result
in sometimes printing a phony truncation warning; but it's just luck
that there was no worse problem, since we were violating the API spec
for truncate_identifier(). Per bug #9204 from Joshua Yanovski.
This has been wrong since the Unicode-identifier support was added,
so back-patch to all supported branches.
Branch
------
REL8_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/a8a46d846c13d1ed07ad0a900e37dd318c8096e2
Modified Files
--------------
src/backend/parser/scan.l | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-02-13 19:52:21 | Re: pgsql: pgindent: preserve blank lines around #else/#endif |
Previous Message | Alvaro Herrera | 2014-02-13 19:07:21 | Re: pgsql: pgindent: preserve blank lines around #else/#endif |