From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: pgindent: preserve blank lines around #else/#endif |
Date: | 2014-02-13 19:07:21 |
Message-ID: | 20140213190720.GE2083@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > pgindent: preserve blank lines around #else/#endif
> >
> > This requires a new version of pg_bsd_indent, version 1.3, to be
> > downloaded.
>
> This is a bit of a mess. I now can't use 9.3's pgindent because it
> wants to have pg_bsd_indent 1.2 installed, but I only have 1.3 because
> the master branch requested it.
BTW did this commit, or other recent pgindent tweaks, have more
implications than we were aware of? I just tried running HEAD's
pgindent in 9.3 (in individual files) and among other changes I saw this
one:
diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
index 17bbcb5..5595f47 100644
--- a/src/backend/access/common/reloptions.c
+++ b/src/backend/access/common/reloptions.c
@@ -624,6 +624,7 @@ transformRelOptions(Datum oldOptions, List *defList, char *namspace,
}
else if (def->defnamespace == NULL)
continue;
+
else if (pg_strcasecmp(def->defnamespace, namspace) != 0)
continue;
This seems an odd change to be making.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-02-13 19:25:27 | pgsql: Fix length checking for Unicode identifiers containing escapes ( |
Previous Message | Alvaro Herrera | 2014-02-13 18:54:54 | Re: pgsql: pgindent: preserve blank lines around #else/#endif |