| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Resolve timing issue with logging locks for Hot Standby. |
| Date: | 2012-02-01 09:31:32 |
| Message-ID: | E1RsWXM-0000LN-1K@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Resolve timing issue with logging locks for Hot Standby.
We log AccessExclusiveLocks for replay onto standby nodes,
but because of timing issues on ProcArray it is possible to
log a lock that is still held by a just committed transaction
that is very soon to be removed. To avoid any timing issue we
avoid applying locks made by transactions with InvalidXid.
Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee
Branch
------
REL9_1_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/8572cc495cd07d4f4a59624d275a75b45340a3b2
Modified Files
--------------
src/backend/storage/ipc/procarray.c | 8 +--
src/backend/storage/ipc/standby.c | 110 ++++++++++++++++++++++++-----------
src/backend/storage/lmgr/lock.c | 12 ++++-
src/include/storage/standby.h | 2 +-
4 files changed, 88 insertions(+), 44 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2012-02-01 09:33:47 | pgsql: Resolve timing issue with logging locks for Hot Standby. |
| Previous Message | Tom Lane | 2012-02-01 07:14:49 | pgsql: Code review for plpgsql fn_signature patch. |