pgsql: Code review for plpgsql fn_signature patch.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Code review for plpgsql fn_signature patch.
Date: 2012-02-01 07:14:49
Message-ID: E1RsUP3-0006kh-Js@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Code review for plpgsql fn_signature patch.

Don't quote the output of format_procedure(); it's already quoted quite
enough. Remove the fn_name field, which was now just dead weight. Fix
remaining expected-output files.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bef47331b6a1c0d081179a7fc9b82dd7e1862394

Modified Files
--------------
src/pl/plpgsql/src/pl_comp.c | 2 -
src/pl/plpgsql/src/pl_exec.c | 8 +-
src/pl/plpgsql/src/pl_funcs.c | 4 +-
src/pl/plpgsql/src/plpgsql.h | 1 -
src/pl/plpython/expected/plpython_error.out | 4 +-
src/pl/plpython/expected/plpython_error_0.out | 4 +-
src/test/regress/expected/domain.out | 16 +++---
src/test/regress/expected/guc.out | 2 +-
src/test/regress/expected/plancache.out | 4 +-
src/test/regress/expected/plpgsql.out | 74 ++++++++++++------------
src/test/regress/expected/triggers.out | 74 ++++++++++++------------
11 files changed, 95 insertions(+), 98 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2012-02-01 09:31:32 pgsql: Resolve timing issue with logging locks for Hot Standby.
Previous Message Tom Lane 2012-01-31 21:30:00 Re: pgsql: Adjust expected regression test outputs for PL/python.