From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Make GIN and GIST pass the index collation to all their support |
Date: | 2011-04-23 00:13:48 |
Message-ID: | E1QDQTs-0005ka-7b@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Make GIN and GIST pass the index collation to all their support functions.
Experimentation with contrib/btree_gist shows that the majority of the GIST
support functions potentially need collation information. Safest policy
seems to be to pass it to all of them, instead of making assumptions about
which ones could possibly need it.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/ae20bf1740c53494e15fadfd8c2c6444032a3441
Modified Files
--------------
src/backend/access/gin/ginget.c | 6 ++--
src/backend/access/gin/ginscan.c | 17 +++++++------
src/backend/access/gin/ginutil.c | 21 +++++++++--------
src/backend/access/gist/gist.c | 17 +++++++++++++
src/backend/access/gist/gistsplit.c | 21 +++++++++-------
src/backend/access/gist/gistutil.c | 43 ++++++++++++++++++++--------------
src/include/access/gin_private.h | 4 +-
src/include/access/gist_private.h | 3 ++
8 files changed, 82 insertions(+), 50 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-04-23 00:20:10 | pgsql: Fix contrib/btree_gist to handle collations properly. |
Previous Message | Tom Lane | 2011-04-22 22:23:46 | pgsql: De-kludge contrib/btree_gin for collations. |