| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: De-kludge contrib/btree_gin for collations. |
| Date: | 2011-04-22 22:23:46 |
| Message-ID: | E1QDOlO-0004Eg-Ae@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
De-kludge contrib/btree_gin for collations.
Using DEFAULT_COLLATION_OID in the comparePartial functions was not only
a lame hack, but outright wrong, because the compare functions for
collation-aware types were already responding to the declared index
collation. So comparePartial would have the wrong expectation about
the index's sort order, possibly leading to missing matches for prefix
searches.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/474ff212e5c2e89a9955cc2355cb96b2fe40398e
Modified Files
--------------
contrib/btree_gin/btree_gin.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-23 00:13:48 | pgsql: Make GIN and GIST pass the index collation to all their support |
| Previous Message | Peter Eisentraut | 2011-04-22 21:49:15 | pgsql: Small update to emacs example configuration |