pgsql: Set indcheckxmin true when REINDEX fixes an invalid or not-ready

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Set indcheckxmin true when REINDEX fixes an invalid or not-ready
Date: 2011-04-20 23:01:45
Message-ID: E1QCgP3-0007R7-EZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Set indcheckxmin true when REINDEX fixes an invalid or not-ready index.

Per comment from Greg Stark, it's less clear that HOT chains don't conflict
with the index than it would be for a valid index. So, let's preserve the
former behavior that indcheckxmin does get set when there are
potentially-broken HOT chains in this case. This change does not cause any
pg_index update that wouldn't have happened anyway, so we're not
re-introducing the previous bug with pg_index updates, and surely the case
is not significant from a performance standpoint; so let's be as
conservative as possible.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9ad7e15507ffa14f51d80d6ae3ed942ea191826d

Modified Files
--------------
src/backend/catalog/index.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-04-21 00:34:59 pgsql: Fix bugs in indexing of in-doubt HOT-updated tuples.
Previous Message Tom Lane 2011-04-20 21:44:30 pgsql: Make plan_cluster_use_sort cope with no IndexOptInfo for the tar