pgsql: Make plan_cluster_use_sort cope with no IndexOptInfo for the tar

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make plan_cluster_use_sort cope with no IndexOptInfo for the tar
Date: 2011-04-20 21:44:30
Message-ID: E1QCfCI-0006Kz-BF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make plan_cluster_use_sort cope with no IndexOptInfo for the target index.

The original coding assumed that such a case represents caller error, but
actually get_relation_info will omit generating an IndexOptInfo for any
index it thinks is unsafe to use. Therefore, handle this case by returning
"true" to indicate that a seqscan-and-sort is the preferred way to
implement the CLUSTER operation. New bug in 9.1, no backpatch needed.
Per bug #5985 from Daniel Grace.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5b8e442953da0bf4950b86c7cb4a6117842aedf7

Modified Files
--------------
src/backend/optimizer/plan/planner.c | 29 ++++++++++++++++++-----------
1 files changed, 18 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-04-20 23:01:45 pgsql: Set indcheckxmin true when REINDEX fixes an invalid or not-ready
Previous Message Hiroshi Inoue 2011-04-20 21:40:47 Re: Re: [COMMITTERS] pgsql: setlocale() on Windows doesn't work correctly if the locale name