| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Clean up role created in new subscription test. |
| Date: | 2023-12-01 11:22:50 |
| Message-ID: | E0EB10CE-9B58-44C0-8CBC-807BC8E5A84A@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> On 8 Nov 2023, at 13:32, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> I suppose you're just thinking of using PQexec() or whatever, run one
> query with sufficient ORDER BY, save the result, and at the end of the
> test run just run the same query and compare that they are cell-by-cell
> identical? This sounds a lot simpler than the patch you posted.
I found some spare cycles for this and came up with the attached. The idea was
to keep it in-line with how pg_regress already today manipulate and traverse
_stringlists for various things. With the addition of the 0001 patch to clean
up global objects left in test_pg_dump it passes check-world.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0002-pg_regress-Detect-global-objects-left-over-after-.patch | application/octet-stream | 4.1 KB |
| v4-0001-Drop-global-objects-after-completed-test.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-12-01 11:37:02 | Re: pgsql: Clean up role created in new subscription test. |
| Previous Message | Peter Eisentraut | 2023-12-01 07:48:52 | pgsql: doc: Update info on information schema usage tables |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-12-01 11:37:02 | Re: pgsql: Clean up role created in new subscription test. |
| Previous Message | Richard Guo | 2023-12-01 11:17:22 | Re: Fix a wrong comment in setrefs.c |