Re: pgsql: pg_rewind: Fetch small files according to new size.

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_rewind: Fetch small files according to new size.
Date: 2022-04-06 10:33:41
Message-ID: DD4C6941-32A6-4819-A867-723CB6D7E1D1@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 6 Apr 2022, at 10:44, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:

> Hmm, it is typical to cast file sizes to long long and print with %lld.
> See d914eb347fcd for a recent example.
>
> .. oh, I see you pushed already. Not sure this is worth fixing, since
> the original commit message claimed to involve only "small files".

The logic is only effective against files smaller than MAX_CHUNK_SIZE which is
1Mb. I should've mentioned that in the fixup commit message, sorry for being
vague.

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-04-06 12:15:19 Re: [COMMITTERS] pgsql: Allow time delayed standbys and recovery
Previous Message Kyotaro Horiguchi 2022-04-06 09:21:16 Re: API stability