From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | alvherre(at)alvh(dot)no-ip(dot)org |
Cc: | robertmhaas(at)gmail(dot)com, markus(dot)wanner(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: API stability |
Date: | 2022-04-06 09:21:16 |
Message-ID: | 20220406.182116.70086612010355256.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
At Wed, 06 Apr 2022 18:13:17 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Wed, 6 Apr 2022 10:30:32 +0200, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote in
> > For code documentation purposes, I think it is slightly better to use
> > bits8 than uint8 for variables where you're storing independent bit flags.
>
> Oh, agreed. Will fix in the next version along with other fixes.
The immediately folloing member statusFlags is in uint8. So using
bits8 here results in the following look.
> bits8 delayChkptFlags;/* for DELAY_CHKPT_* flags */
>
> uint8 statusFlags; /* this backend's status flags, see PROC_*
> * above. mirrored in
PGPROC has another member that fits bits*.
> uint64 fpLockBits; /* lock modes held for each fast-path slot */
Do I change this in this patch? Or leave them for another chance?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2022-04-06 10:33:41 | Re: pgsql: pg_rewind: Fetch small files according to new size. |
Previous Message | Kyotaro Horiguchi | 2022-04-06 09:13:17 | Re: API stability |
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2022-04-06 09:24:28 | Re: shared-memory based stats collector - v70 |
Previous Message | Kyotaro Horiguchi | 2022-04-06 09:13:17 | Re: API stability |