Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

> On 20 Apr 2023, at 11:51, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net> wrote:
>
>> Am 20.04.2023 um 10:50 schrieb Daniel Gustafsson <daniel(at)yesql(dot)se>:
>>
>> Skimming other callsites of ReadDir and readdir I didn't see any others
>> which could benefit from skipping hidden files.
>
> Could /src/bin/pg_rewind/filemap.c be another candidate for skipping hidden files? The 'copy all other files'-behaviour seems to be similar to what pg_basebackup does and it uses the same exclude_list_item blacklist mechanism.

Maybe. I'm a bit hesitant to add too many smarts to pg_rewind. It's a tool
for when something has gone wrong with a cluster (albeit probably not at the
filesystem level), and at that point I feel it's better to put the user fully
in charge. Perhaps I'm overly cautious, curious to hear from others.

--
Daniel Gustafsson