| From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | xu(dot)xw2008(at)163(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17903: There is a bug in the KeepLogSeg() |
| Date: | 2023-04-20 11:17:02 |
| Message-ID: | CAEG8a3Kx2tO4d0kaDH8-75LthUtOc_A2HEZFpkgGcQ4NB1A=vA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
This patch looks reasonable.
+1
On Thu, Apr 20, 2023 at 4:58 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Thu, 20 Apr 2023 15:40:14 +0800, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote in
> > If `segno` can be larger than `currSegNo`, your patch seems to miss
> > the following branch,
> > are you missing this for some particular reason?
>
> Oops! Sorry for the mistake and thanks for pointing it out.
>
> I should have kept segno within the reasonable range.
>
> regards.
>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center
--
Regards
Junwang Zhao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-04-20 19:47:21 | Re: Assert failure with ICU support |
| Previous Message | Daniel Gustafsson | 2023-04-20 11:15:40 | Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files |