Re: testclient.exe installed under MSVC

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Jacob Champion <pchampion(at)vmware(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: testclient.exe installed under MSVC
Date: 2022-05-03 13:04:26
Message-ID: D37C9BAD-B9FB-4D18-A2DF-0A09DB55709D@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 3 May 2022, at 04:02, Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Mon, May 02, 2022 at 03:14:50PM +0200, Daniel Gustafsson wrote:

>> Renaming is probably the best option given how MSVC works. Using a pg_ prefix
>> makes them sound like actual useful tools though with (albeit small) risk for
>> confusion? Noah's suggestion of libpq_ is perhaps better: libpq_testclient.
>
> Agreed. libpq_testclient and libpq_uri_regress sound fine.

The attached works in both Linux and (Cirrus CI) MSVC for me.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
0001-Rename-libpq-test-programs-with-libpq_-prefix.patch application/octet-stream 8.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-05-03 13:07:47 Re: fix cost subqueryscan wrong parallel cost
Previous Message Peter Smith 2022-05-03 08:54:33 Re: Skipping schema changes in publication